VM 0622RC1 Issues

Overview

There are a few issues with the latest VM that came up when implementing new features, such as paging. Some have been fixed, below are those that remain. Feel free to categorize them as Critical, Major, or Minor, or take control of any to be fixed.

Issues

1

  • Even unapproved site managers show up when searching by Site Manager skill.
  • Notes: use a view vm_vol_skills_approved, something to the effect of select * from vm_vol_skills where opt_skill_type <> 'MGR' union select * from vm_vol_skills where opt_skill_type = 'MGR' and status='approved' , and then select on this view rather than selecting on vm_vol_skills. In fact, using this view can also fix #9 below.
    • Priority: HIGH
    • Assigned to:

2

  • Site manager can remove himself from the project
  • Notes: Prevent site manager from being removed from project at all.
    • Priority: HIGH
    • Assigned to:

3

  • Site manager can add non-site managers to the site manager position, although they do not gain any extra permissions.
    • Priority: HIGH
    • Assigned to:

4

  • Should add paging to approve abilities page.
    • Priority: HIGH
    • Assigned to:

5

  • For paging, need to fix the navigation when a page is requested beyond the available pages. Right now, for example, if there are 5 pages and the 6th is requested by manipulating the URL, the last page is correctly displayed, but the navigation shows the wrong page.
  • Question: Wouldn't this bug require modification to the Sahana paging library--since that is where the requested page is retrieved from the $_REQUEST parameters??
  • Response: It shouldn't. The Sahana library and DAO::getCurrentPage() return the last page when a page out of the range of maximum pages is given. We just need to modify our navigation template to reflect that when it happens.
    • Priority: CRITICAL
    • Assigned to:

6

  • Some information in the Volunteer Object may need standardizing for future use, such as Volunteer::info['locations'] and Volunteer::info['location_names'], which should be consolidated into one. Also, Volunteer::info['skills'] is not consistent throughout the module, although all functionality appears correct.
    • Priority: MINOR
    • Assigned to:

7

  • Name searches are no longer sorted by levenshtein distance because all searching must be done in one database query due to paging, and levenshtein used to be done through PHP. It would be nice to sorted name search results somehow by closest match
    • Priority: MINOR
    • Assigned to:

8

  • Nice feature to paging would be to add a page jump text box, where you could jump to any given page.
    • Priority: MINOR
    • Assigned to:

9

  • Site Manager skill shows up for a volunteer even if it has not yet been approved.
    • Priority: HIGH
    • Assigned to: